fix: use portable shebang in sample hooks#1815
Open
maxonvim wants to merge 1 commit intobasecamp:mainfrom
Open
fix: use portable shebang in sample hooks#1815maxonvim wants to merge 1 commit intobasecamp:mainfrom
maxonvim wants to merge 1 commit intobasecamp:mainfrom
Conversation
On some systems, like NixOS or certain BSDs, the shell isn't located at /bin/sh. Using #!/usr/bin/env sh instead resolves this by searching the user's PATH, matching the pattern already used in the Ruby sample hooks.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shebangs in shell script sample hooks to use a more portable pattern that works across different systems like NixOS and certain BSD distributions.
Changes:
- Updated shebangs from
#!/bin/shto#!/usr/bin/env shin seven shell sample hook files (pre-proxy-reboot, pre-build, pre-app-boot, post-proxy-reboot, post-deploy, post-app-boot, and docker-setup) - This aligns with the pattern already established in the Ruby sample hooks (pre-connect and pre-deploy)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/kamal/cli/templates/sample_hooks/pre-proxy-reboot.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/pre-build.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/pre-app-boot.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/post-proxy-reboot.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/post-deploy.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/post-app-boot.sample | Updated shebang to portable format |
| lib/kamal/cli/templates/sample_hooks/docker-setup.sample | Updated shebang to portable format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some systems, like NixOS or certain BSDs, the shell isn't located at
/bin/sh. Using#!/usr/bin/env shinstead resolves this by searching the user'sPATH, matching the pattern already used in the Ruby sample hooks (pre-connect.sampleandpre-deploy.sample).