Skip to content

Fix duplicate rich-editor Tab suggestion inserts#310

Merged
bartekplus merged 2 commits intomasterfrom
codex/fix-rich-editor-tab-dedupe
Mar 13, 2026
Merged

Fix duplicate rich-editor Tab suggestion inserts#310
bartekplus merged 2 commits intomasterfrom
codex/fix-rich-editor-tab-dedupe

Conversation

@bartekplus
Copy link
Owner

Summary

  • deduplicate rich-editor Tab accepts so the early bridge and the normal keydown path cannot both accept the same suggestion while the first edit is still pending
  • stop forcing an immediate DOM fallback when a generic contenteditable host cancels beforeinput without an immediate mutation, which was duplicating inserts on async hosts like Reddit and Facebook
  • add regression coverage for both failure modes in the suggestion session and text-edit service tests

Test Plan

  • bun run lint
  • bun run format:check
  • bun test tests/SuggestionTextEditService.test.ts tests/SuggestionEntrySession.test.ts tests/SuggestionManager.test.ts tests/content_script.behavior.test.ts
  • bun run test:e2e
  • bun run test:e2e --platform=firefox

@bartekplus bartekplus force-pushed the codex/fix-rich-editor-tab-dedupe branch from 8689923 to daa5e33 Compare March 13, 2026 10:07
@bartekplus bartekplus merged commit 9721eb7 into master Mar 13, 2026
8 checks passed
@bartekplus bartekplus deleted the codex/fix-rich-editor-tab-dedupe branch March 13, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant