Make Windows elevate paths UTF-8 compatible#23
Open
WolfHawkeAI wants to merge 1 commit into
Open
Conversation
This is so that we can use strings with characters not in cp1252, such as Turkish characters ş ı ğ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using elevate to run a script on a Turkish-localized computer with non-cp1252 characters (e.g. ğ ı ş) in the path, the script throws the following error (code is edited to obfuscate actual working environment and Turkish characters are an example):
In playing with the code in windows.py changing lines 77 and 78 to
will allow the script to run in Windows Command Prompt (cmd.exe). However, it will not run in PowerShell (tried in 5.1 and 7.4.3), because the output path looks like:
C:\Users\####\yağdır\venv\Scripts\python.exe. Not exactly sure how to overcome that issue yet.