feat: transformCss no longer inits lightningcss#25
Open
jptaranto wants to merge 1 commit intobalintbrews:mainfrom
Open
feat: transformCss no longer inits lightningcss#25jptaranto wants to merge 1 commit intobalintbrews:mainfrom
jptaranto wants to merge 1 commit intobalintbrews:mainfrom
Conversation
BREAKING CHANGE: lightningcss must be loaded manually if you are not using buildCss.
jptaranto
commented
Feb 3, 2026
| // Get the version of the `lightningcss-wasm` package. It will be added to the | ||
| // bundled WASM file's filename in the `tsup` config below (`esbuildOptions` → | ||
| // `assetNames`). | ||
| const lightningCssWasmVersion = await (async (): Promise<string> => { |
Author
There was a problem hiding this comment.
I was unable to get the import working when the wasm file had a version number in it, so I removed it.
jptaranto
commented
Feb 3, 2026
| // CAVEAT: The `banner` option can add an arbitrary to string to all | ||
| // generated JS and CSS files, but there is no way to limit it to only the | ||
| // `index.js` file. What's lucky is that it's the only generated JS file. | ||
| js: `import './lightningcss_node-${lightningCssWasmVersion}.wasm?url';`, |
Author
There was a problem hiding this comment.
I believe this isn't necessary anymore but I might be wrong. The buildCss function thats output in dist/index.js correctly references the output dist/lightningcss_node.wasm file.
jptaranto
commented
Feb 3, 2026
| css: string, | ||
| { minify = true }: TransformCssOptions = {}, | ||
| ): Promise<string> { | ||
| await lightningCssInit(new URL(lightningCssWasm, import.meta.url).href); |
Author
There was a problem hiding this comment.
This is moved into buildCss - so hopefully the API is unaffected, but we can manually init ourselves now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: lightningcss must be loaded manually if you are not using buildCss.