Refactor application structure and enhance logging and testing#63
Open
adeyinkaoresanya wants to merge 45 commits into
Open
Refactor application structure and enhance logging and testing#63adeyinkaoresanya wants to merge 45 commits into
adeyinkaoresanya wants to merge 45 commits into
Conversation
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…elopment Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…t is parsed as number in database setup Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ring service to use it for badge calculation Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ller methods Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ents Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
… baseUrl Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…okit Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ng purposes Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…gingController Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ors correctly Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ody correctly Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…handling and code clarity Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
… logging capabilities Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…processing Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…d logging Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
… services and configuration Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…etter error tracking Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…ck.json Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…egration tests Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
…st isolation Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
Signed-off-by: AdeyinkaOresanya <adeyinkaoresanya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
This pull request introduces several improvements and refactors across the codebase, focusing on environment configuration, authentication flow, middleware and error handling, and developer tooling. The most significant changes are the refactoring of the authentication controller for better clarity and error handling, the addition of new environment variables for event badging and database configuration, and the introduction of a custom Jest configuration with proper environment setup for testing.
Key changes include:
Authentication Flow and Error Handling
AuthControllerto improve clarity, error handling, and maintainability:AppErrorclass for error responses.Environment and Configuration
.env.examplewith new variables for event badging OAuth, GitHub App installation, test database configuration, and webhook paths to support additional deployment and testing scenarios. [1] [2]Middleware and Application Structure
src/app.tsto:SystemControllerfor system-level endpoints.requestLoggerandglobalErrorHandlermiddleware.Testing and Developer Tooling
jest.config.ts) and setup file (jest.setup.ts) to load environment variables and support TypeScript testing.package.jsonto use the new Jest setup, run tests in-band, and add/upgrade related dependencies (e.g.,ts-jest,supertest,winston). [1] [2] [3] [4] [5]Miscellaneous
.vscode/settings.jsoncontaining hardcoded database credentials for improved security and portability..husky/pre-commitscript output for consistency.These changes collectively improve the maintainability, security, and testability of the project.