⚡ Bolt: [performance improvement]#42
Conversation
Implemented a hybrid sampling strategy in `random.html` to avoid the "Coupon Collector's Problem" when high-density unique selections are requested. - Use rejection sampling (Set) for sparse requests (< 50% range). - Use exclusion sampling (array swap and pop) for dense requests (> 50% range). - Provides a ~6.5x speedup for high-density scenarios (e.g., 9,999/10,000). Co-authored-by: babelman97 <186798789+babelman97@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized the unique random number generation logic in
random.htmlby introducing a hybrid sampling strategy.🎯 Why: The previous implementation used rejection sampling exclusively. This suffers from the "Coupon Collector's Problem" where picking the last few unique values from a range takes exponentially more attempts, causing significant performance degradation and potential UI freezes in high-density requests.
📊 Impact: Benchmarks show an average speedup of ~6.5x for high-density cases (picking 9,999 unique numbers from a range of 10,000), reducing execution time from ~5.0ms to ~0.77ms.
🔬 Measurement: Verified with a Playwright script ensuring correctness (all numbers unique and in range) and measured using a high-amplification benchmark script (100 iterations).
PR created automatically by Jules for task 16241391000612632402 started by @babelman97