Skip to content

fix(WG): Grant quest credit for non-lieutenant WG kills in CFBG#144

Merged
Nyeriah merged 1 commit into
azerothcore:masterfrom
Nyeriah:fix/wg-pvp-quest-credit-non-lieutenant
May 17, 2026
Merged

fix(WG): Grant quest credit for non-lieutenant WG kills in CFBG#144
Nyeriah merged 1 commit into
azerothcore:masterfrom
Nyeriah:fix/wg-pvp-quest-credit-non-lieutenant

Conversation

@Nyeriah
Copy link
Copy Markdown
Member

@Nyeriah Nyeriah commented May 17, 2026

Changes Proposed:

In CFBG Wintergrasp, "No Mercy for the Merciless" / "Slay Them All" quest credit was silently lost whenever the victim had not yet earned SPELL_LIEUTENANT (which requires 10 WG kills in the current session). In short or low-population sessions nobody ever reaches that rank, so the quests effectively never progress.

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Implementation

Uses the new OnBattlefieldPlayerKill hook (added in the companion core PR) to grant KilledMonsterCredit to all nearby war-teammates of the killer for every player kill, bypassing the lieutenant gate. Double-credit on lieutenant kills is avoided by returning early when the victim already has SPELL_LIEUTENANT — the core's existing loop handles those.

Credit NPC selection mirrors the core logic and uses killer->GetTeamId(), which correctly reflects the CFBG-assigned fake team, so the right NPC (31086 for Alliance kills, 39019 for Horde kills) is always chosen.

Depends on: azerothcore/azerothcore-wotlk#25871

AI-assisted Pull Requests

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Claude Sonnet 4.6 was used to implement this change.

Issues Addressed:

  • Closes N/A

SOURCE:

The changes have been validated through:

  • Live research
  • Sniffs
  • Video evidence, knowledge databases or other public sources
  • Cherry-pick

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request requires further testing.
  1. Apply the companion core PR first.
  2. Enable CFBG.Battlefield.Enable = 1 in the CFBG config.
  3. Enter Wintergrasp with a crossfaction group (Horde assigned to Alliance WG team, or vice versa).
  4. Pick up "No Mercy for the Merciless" (Alliance) or "Slay Them All" (Horde) from the WG commander.
  5. Kill an enemy player who does not have a WG rank aura yet.
  6. Confirm the quest counter advances.
  7. Kill an enemy player who does have SPELL_LIEUTENANT and confirm the counter advances exactly once (no double-credit).

Known Issues and TODO List:

  • [ ]
  • [ ]

In CFBG Wintergrasp, quest credit for "No Mercy for the Merciless" /
"Slay Them All" was silently lost for kills where the victim had not yet
earned SPELL_LIEUTENANT (requiring 10 WG kills in the current session).

Uses the new OnBattlefieldPlayerKill hook to grant KilledMonsterCredit to
all nearby war-teammates of the killer for every player kill, bypassing
the lieutenant gate. Double-credit on lieutenant kills is avoided by
returning early when the victim already has SPELL_LIEUTENANT (the core's
existing loop handles those).

Credit NPC selection mirrors the core logic and correctly uses the
killer's GetTeamId(), which reflects the CFBG-assigned fake team.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Nyeriah Nyeriah merged commit eabd953 into azerothcore:master May 17, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant