docs: recommend job summary reports#17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle-size-comparison.mdto$GITHUB_STEP_SUMMARYas the safe way to surface reports from pull-request-controlled code.Testing
Docs-only change; tests and build were not run.
pnpm testpnpm run buildChecklist
dist/index.jswhen runtime source, dependencies, or action metadata changed.Summary by cubic
Recommend surfacing bundle-size reports via GitHub Actions job summaries instead of PR comments. This removes risky/complex comment workflows and shows the safe way to display reports from PR code.
pull_requestworkflow that runsaxios/bundle-size@main, appendbundle-size-comparison.mdto$GITHUB_STEP_SUMMARY(e.g.,cat bundle-size-comparison.md >> "$GITHUB_STEP_SUMMARY"). Remove any PR comment steps orworkflow_runcomment workflows.Written for commit cdf2f0b. Summary will update on new commits. Review in cubic