Optimize schedule() to skip finished task early#260
Merged
jorajeev merged 1 commit intoawslabs:mainfrom Apr 7, 2026
Merged
Conversation
jorajeev
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our longbake test based on shuttle started to experience timeouts during transaction execution after one merge from live bumping Rust version from 1.92 to 1.93, and the problem sustains when rust bump to 1.94. After some investigations, we were able to discover the following:
The new compiler restructured the branch logic. The old code had a fast path: if task.finished() (state == 5), immediately skip. The new code does more work even for finished tasks — it
falls through into additional comparisons before skipping.
With ~500 tasks and ~12M calls to schedule(), and most tasks being finished, this means billions of extra instructions on the "finished task" fast path.
This is a classic LLVM codegen regression — the optimizer restructured the branch conditions in a way that's worse for the common case (most tasks are finished).
So this change is essentially adding the optimization back in rust code. And proved the longbake run succeeded after this change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.