fix: correct module path mapping for ZIP deployment#94
Open
naumaanh wants to merge 2 commits intoawslabs:mainfrom
Open
fix: correct module path mapping for ZIP deployment#94naumaanh wants to merge 2 commits intoawslabs:mainfrom
naumaanh wants to merge 2 commits intoawslabs:mainfrom
Conversation
The ZIP packager was reading the wrong source directories when building the deployment artifact, causing ModuleNotFoundError crashes at runtime. Also fixes AgentCore Runtime not picking up updated ZIPs on redeploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #93 :ZIP deployment fails with HTTP 424 "Runtime initialization time exceeded"
Description of changes:
When using
deployment_type: zip, the agent crashes on startup with ModuleNotFoundError which surfaces asHTTP 424 "Runtime initialization time exceeded"in the UI.The ZIP packager in
backend-stack.tswas pointing at the wrong source folders and missing one entirely, so the Python modules the agent imports at startup simply weren't included in the ZIP. Docker worked fine because it has explicit COPY commands mapping the right folders. The ZIP packager was not replicating that mapping.A secondary issue meant CloudFormation wouldn't push an updated ZIP to the running Runtime on redeploy because the Runtime resource definition never changed (same S3 bucket, same key), so it left the Runtime running the old artifact.
The fix was replacing a generic loop with explicit directory reads that mirror the Dockerfile COPY commands. Also embeds a short fingerprint of the ZIP contents in the Runtime description so CloudFormation detects a real change and re-deploys the Runtime whenever the ZIP is updated.
Docker deployments are unaffected, the changed code only runs inside the
if (deploymentType === "zip")block.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.