Remove git dependency from CodeBuild deployment script#91
Remove git dependency from CodeBuild deployment script#91
Conversation
|
Latest scan for commit: Security Scan ResultsScan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies: Column Explanations: Severity Levels (S/C/H/M/L/I):
Other Columns:
Scanner Results:
Severity Thresholds (Thresh Column):
Threshold Source: Values in parentheses indicate where the threshold is configured:
Statistics calculation:
|
19a4f58 to
e103c91
Compare
e103c91 to
7c19e2e
Compare
brianz
left a comment
There was a problem hiding this comment.
One small comment but otherwise I trust that this is a good change.
|
|
||
| ### Option B: Deploy via CodeBuild | ||
|
|
||
| Requires only Python 3.8+ and AWS CLI — no Node.js, Docker, or CDK needed. |
There was a problem hiding this comment.
Let's update this to a more modern Python version. I believe other docs state python 3.11+. 3.8 is EOL and released almost 7 years ago.
There was a problem hiding this comment.
Makes sense, updated to 3.11+ consistent with the rest of the project.
848ccd7 to
7257716
Compare
Problem
The current
deploy-with-codebuild.pyscript usesgit ls-filesto enumerate files for packaging, which creates Hard dependency on git and Untracked files are silently dropped.Solution
Replace
git ls-fileswith a filesystem walk that explicitly excludes common build artifacts and environment directories.Changes:
os.walk()instead of shelling out to git.git,node_modules,__pycache__,.pytest_cache,cdk.out,.venv,venv,dist,build,.DS_Store,.env,.env.local,*.pyc,.coverage