fix: Replace plain SHA-256 with HMAC-SHA256 for remote function artifact integrity#5602
Draft
mollyheamazon wants to merge 1 commit intoaws:masterfrom
Draft
fix: Replace plain SHA-256 with HMAC-SHA256 for remote function artifact integrity#5602mollyheamazon wants to merge 1 commit intoaws:masterfrom
mollyheamazon wants to merge 1 commit intoaws:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
PR #5379 replaced the original HMAC-based integrity check with plain SHA-256 hashing for remote function serialized artifacts. While this removed the prior
vulnerability of exposing the HMAC key via DescribeTrainingJob environment variables, it introduced a new one: an attacker with S3 write access can recompute
the SHA-256 hash for a malicious payload and replace both payload.pkl and metadata.json, bypassing integrity verification entirely and achieving arbitrary
code execution via cloudpickle.loads().
Solution
Re-introduce HMAC-SHA256 signing with the key stored in AWS Secrets Manager instead of environment variables. Add a Parameter Store trust anchor to prevent an
attacker from pointing metadata at an attacker-controlled secret.
Signing (serialization):
Verification (deserialization):
Why this is secure
An attacker with S3 write access can replace payload.pkl and metadata.json, but cannot:
Breaking change
This is intentionally a breaking change. The legacy plain SHA-256 path is removed. Existing remote function jobs in-flight during upgrade will fail
deserialization and need to be re-run. Given the small user base (~8 customers), this is acceptable to avoid maintaining a vulnerable fallback.
New IAM permissions required
Execution roles used with @Remote / RemoteExecutor need:
arn:aws:secretsmanager:*:*:secret:sagemaker/remote-function/*TODO before merge
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.