fix(dataset): tui back-navigation bugs + kmsKeyArn support#1379
Open
jariy17 wants to merge 3 commits into
Open
fix(dataset): tui back-navigation bugs + kmsKeyArn support#1379jariy17 wants to merge 3 commits into
jariy17 wants to merge 3 commits into
Conversation
Three back-navigation issues reported on PR #1347: 1. BatchEvalWizard Escape skips source-picker — onExit passed the top-level exit handler instead of returning to the source-picker state. Now returns to source-picker on first-step back-nav. 2. AddDatasetScreen loses typed name — initialValue always called generateUniqueName() ignoring the stored name state. Now uses the previously submitted name when available. 3. DatasetFlow back-nav resets datasets to [] — all four sub-screen onExit/onCancel handlers hardcoded an empty array. Added loadedDatasets state that persists across flow transitions.
Wire kmsKeyArn through the full add-dataset flow: - CLI: --kms-key-arn flag with ARN validation - TUI: optional step after Description (Enter to skip) - Primitive: writes kmsKeyArn to agentcore.json when provided - CDK construct already passes KmsKeyArn to CloudFormation The field is immutable after dataset creation (createOnly CFN property).
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1379-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Coverage Report
|
github-actions
Bot
removed
the
agentcore-harness-reviewing
Cover the kmsKeyArn flow with: - Unit: DatasetPrimitive.add() persists kmsKeyArn when provided, omits when absent - Integ: CLI --kms-key-arn writes to agentcore.json, invalid ARN rejected, absent ARN omitted
jariy17
changed the title
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jariy17
force-pushed
the
dataset-tui-kmsKey-fix
branch
from
9b2d82a to
ed30251
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 3 TUI back-navigation bugs reported on feat: dataset management — full feature with tests #1347 by @padmak30:
Wire
kmsKeyArnthrough the add-dataset flow (flagged by @padmak30, confirmed by @jariy17 as dropped during rebase):--kms-key-arn <arn>flag with ARN validationkmsKeyArntoagentcore.jsonKmsKeyArnto CloudFormation (no CDK changes needed)Test plan
tsc --noEmit)agentcore add dataset --helpshows--kms-key-arnflag--kms-key-arn, verifyagentcore.jsoncontains field