Trinity contrib - Fix notebook for upstream clone and add LNC documentation#91
Open
jimburtoft wants to merge 1 commit intoaws-neuron:mainfrom
Open
Trinity contrib - Fix notebook for upstream clone and add LNC documentation#91jimburtoft wants to merge 1 commit intoaws-neuron:mainfrom
jimburtoft wants to merge 1 commit intoaws-neuron:mainfrom
Conversation
- Fix nki-library install: use clone+copy workaround (pip install fails due to setuptools_scm issue) - Fix HF_TOKEN: replace Python syntax in %%bash cell with proper bash - Fix sys.path: point to /home/ubuntu/nxdi/ (upstream clone) not nxdi-fork - Fix Nano TP: change from TP=2 to TP=1 (TP=2 invalid with LNC=2) - Add kernel restart warnings between model sections (NeuronCore OOM) - Add LNC configuration section to README with valid TP degrees - Update validated results to match upstream testing (TP=1 Nano, +28% Mini)
truongp-aws
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Trinity contrib demonstration notebook -- no model code changes.
Testing
I ran the notebook on a trn2.3xlarge with SDK 2.28
By submitting this PR, I confirm that: