Skip to content

Final: first version.#5

Open
JadrankoLucic wants to merge 3 commits intoavl-cpp-training:masterfrom
JadrankoLucic:master
Open

Final: first version.#5
JadrankoLucic wants to merge 3 commits intoavl-cpp-training:masterfrom
JadrankoLucic:master

Conversation

@JadrankoLucic
Copy link
Copy Markdown

Kritike i komentari dobrodošli.

@ncaklovic
Copy link
Copy Markdown
Contributor

Svi testovi prolaze :-), to je dobro.
Možeš ih pisati kraće, poput

    block_processor bp;
    bp.add_block(block_factory::Create("add", { 5 }));
    Assert::AreEqual(10., bp.calc_all(5.));

Nema calc_all sa više vrijednosti (iz ulaznog filea, zadnji dio zadatka)?

@JadrankoLucic
Copy link
Copy Markdown
Author

  1. dodat ću još testova
  2. smetnuo sam (ustvari nisam niti gledao) task: "unijeti naziv tekstualne datoteke sa nizom vrijednosti - izvršit će se svi blokovi nad svim vrijednostima i snimiti izlazni file sa rezultatima". To ću isto napraviti.
  3. dodat ću još blokova (možda)

Copy link
Copy Markdown

@jan-kelemen jan-kelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review na zahtjev od @JadrankoLucic

jadranko lucic added 2 commits November 28, 2018 15:11
- process inputs from file
- more tests
- some refactoring
- new methods on block_processor: load_from_stream, bulk_calc, get_block_command_from_text
New tests
Refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants