Open
Conversation
added 4 commits
November 15, 2018 14:12
- make unit tests pass :)
- make unit tests pass
- improve difference test
Contributor
|
Ponešto prijedloga:
|
- find and operator[] searched through map two times, use what find found if it did - use towlower to avoid 10 comparisons - 4 if statements replaced with ternary operator - replace sort+reverse with sort using reverse iterator - add another option with lambda for opposite comparison (if there is no overloaded operator<)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both exercises