Conversation
|
Hey, thanks for making this, big work! I'm away these days, will check once get fully back |
|
@Thogsit Btw for linux - does it packs with lib_mpv or that should be installed separately? |
Good point, I've got I'm away for work this week, so won't check back on this until next week :) |
Sorry, been away as well. Ill check PR over weekends |
69cb770 to
48ec64f
Compare
48ec64f to
3fa903a
Compare
|
Finally I'm back from vacation and took a look at it again :). I've now added information to the main This should make this PR as far as I'm concerned ready for merging 👍. |
Hey, welcome back! And thanks for your work. I'll have a bit of time over weekends to check and merge it! |
| - name: Release to github | ||
| uses: softprops/action-gh-release@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
This one that starts with GHP_ right?
Goal
This PR contains a new workflow file that has build jobs for the 3 major OSs Linux, Windows and MacOS.
Each build results gets uploaded and published in a new release with the branches' name.
TODOs (can also be adressed via later PRs)
v<whatever>branch is created with it's ownv<whatever>release on the Releases page. How this could look can be seen here. Feel free to suggest how you want to handle releases and I'd be glad to change this PR accordingly :).media_kit_lib_<windows>or whatever dependency in thepubspec.yaml. I'll try that when I get to it.EDIT: Tried on native Windows, music doesn't work as with Wine on Linux. I'll work on it. Also, on Windows no Minimize/Maximize/Close buttons exist and the window is not movable via dragging; I'll try out the same migration from
window_managerto thebitsdojoone which should fix that.