Convert numeric socket messages to numbers before sending to OSC#27
Open
samcarsonx wants to merge 1 commit intoautomata:masterfrom
Open
Convert numeric socket messages to numbers before sending to OSC#27samcarsonx wants to merge 1 commit intoautomata:masterfrom
samcarsonx wants to merge 1 commit intoautomata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When numeric values are sent to the socket, they are parsed as strings and subsequently sent out via OSC as strings too (e.g.,
"5"instead of5). This causes issues with programs like Wekinator that expect properly formatted numeric data.Solution
This fix traverses the list of values and converts any numeric strings to floats before sending them via OSC. Fixes #26
Impact
This fundamentally changes how the program sends data. If merged, I recommend updating the version number to 0.2.2 to reflect this change.