Skip to content

Adds support to GET/PATCH default Custom domain#958

Open
kailash-b wants to merge 1 commit intomasterfrom
feat/SDK-8309-2
Open

Adds support to GET/PATCH default Custom domain#958
kailash-b wants to merge 1 commit intomasterfrom
feat/SDK-8309-2

Conversation

@kailash-b
Copy link
Copy Markdown
Contributor

Changes

Adds support for the GET and PATCH /custom-domains/default Management API endpoints, allowing callers to retrieve and set the default custom domain for a tenant.

Endpoints added:

  • GET /api/v2/custom-domains/default — retrieves the default custom domain
  • PATCH /api/v2/custom-domains/default — sets the default custom domain

Classes and methods added:

  • ICustomDomainsClient.GetDefaultAsync() — retrieves the default CustomDomain for the tenant
  • ICustomDomainsClient.SetDefaultAsync(CustomDomainSetDefaultRequest) — sets the default custom domain by domain name
  • CustomDomainSetDefaultRequest — new request model with a Domain property

Usage example:

// Get the default custom domain
var defaultDomain = await managementClient.CustomDomains.GetDefaultAsync();

// Set a custom domain as the default
var updated = await managementClient.CustomDomains.SetDefaultAsync(
    new CustomDomainSetDefaultRequest { Domain = "login.example.com" });

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner March 30, 2026 11:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.17%. Comparing base (f979eff) to head (2d991d8).

Files with missing lines Patch % Lines
...agementApi/Models/CustomDomain/CustomDomainBase.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   80.21%   80.17%   -0.04%     
==========================================
  Files         464      465       +1     
  Lines        6045     6053       +8     
  Branches      293      293              
==========================================
+ Hits         4849     4853       +4     
- Misses       1104     1108       +4     
  Partials       92       92              
Flag Coverage Δ
authIntTests 30.64% <0.00%> (-0.05%) ⬇️
mgmtIntTests 61.27% <87.50%> (+1.06%) ⬆️
unittests 18.23% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@tanya732 tanya732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants