Skip to content

UPSTREAM PR #21539: vulkan: Support Q1_0#1337

Open
loci-dev wants to merge 1 commit intomainfrom
loci/pr-21539-q1_0
Open

UPSTREAM PR #21539: vulkan: Support Q1_0#1337
loci-dev wants to merge 1 commit intomainfrom
loci/pr-21539-q1_0

Conversation

@loci-dev
Copy link
Copy Markdown

@loci-dev loci-dev commented Apr 7, 2026

Note

Source pull request: ggml-org/llama.cpp#21539

Overview

Add Q1_0 support to ggml-vulkan. Supports get_rows, set_rows, mul_mat(id). Does not support the q8_1 dp4 path (though this is probably worth adding in a followon), since we get the most benefit with smaller quants.

Additional information

None.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: I used Claude to write the majority of this change. I reviewed all the code and had it rewrite several things for consistency, and I rewrote the coopmat2 dequant function myself.

@loci-review
Copy link
Copy Markdown

loci-review Bot commented Apr 7, 2026

No meaningful performance changes were detected across 125311 analyzed functions in the following binaries: build.bin.libllama.so, build.bin.llama-tts, build.bin.llama-cvector-generator, build.bin.llama-bench, build.bin.libmtmd.so, build.bin.libggml.so, build.bin.libggml-cpu.so, build.bin.libggml-base.so, build.bin.llama-tokenize, build.bin.llama-gemma3-cli, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli, build.bin.llama-quantize, build.bin.llama-qwen2vl-cli.

💬 Questions? Tag @loci-dev

@loci-dev loci-dev force-pushed the main branch 8 times, most recently from 06d9e10 to e800934 Compare April 14, 2026 02:18
@loci-dev loci-dev force-pushed the main branch 7 times, most recently from 7638ab4 to f1b46d5 Compare April 20, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants