on up/down arrow, set the input only if data.val is a string#67
Merged
jackmatt2 merged 2 commits intoaupac:masterfrom Jul 8, 2018
Gridium:arrow-object-data
Merged
on up/down arrow, set the input only if data.val is a string#67jackmatt2 merged 2 commits intoaupac:masterfrom Gridium:arrow-object-data
jackmatt2 merged 2 commits intoaupac:masterfrom
Gridium:arrow-object-data
Conversation
with fix: arrow into results leaves input changed
Member
|
@kielni can you merge with master and commit again. I think travis might start passing again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what to do with this fix; it looks like corejavascript/typeahead is no longer maintained (see Mar 28 2018 comment on corejavascript/typeahead.js#181).
This uses my forked version of corejavascript/typeahead.js with an update to leaves input unchanged when navigating through object results with arrow keys: see corejavascript/typeahead.js#184