Fix problem where rtepack types were not parsable (nor probably binary compatible)#1105
Merged
riclarsson merged 2 commits intoatmtools:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make rtepack wrapper types (e.g., stokvec, specmat, propmat, muelmat) correctly parseable/streamable via the XML IO system by fixing binary IO directionality and adding a span-adapter for types that inherit from existing XML-IO-enabled base types.
Changes:
- Corrects the
xml_io_streambinary streaming API to useget(span<T>, bifstream*)for reads andput(span<const T>, bofstream*)for writes. - Introduces
xml_io_stream_inherit<T, U>to adaptstd::span<T>tostd::span<U>for binary/text streaming methods. - Switches
rtepackXML IO specializations to usexml_io_stream_inheritinstead of inheritingxml_io_stream<U>directly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/core/xml/xml_io_stream.h |
Fixes binary IO method signatures and adds xml_io_stream_inherit to bridge span-based IO between derived/base types. |
src/core/rtepack/rtepack_stokes_vector.h |
Updates xml_io_stream<rtepack::stokvec> to use the new inheritance/span adapter. |
src/core/rtepack/rtepack_spectral_matrix.h |
Updates xml_io_stream<rtepack::specmat> to use the new inheritance/span adapter. |
src/core/rtepack/rtepack_propagation_matrix.h |
Updates xml_io_stream<rtepack::propmat> to use the new inheritance/span adapter. |
src/core/rtepack/rtepack_mueller_matrix.h |
Updates xml_io_stream<rtepack::muelmat> to use the new inheritance/span adapter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.