Skip to content

Fix problem where rtepack types were not parsable (nor probably binary compatible)#1105

Merged
riclarsson merged 2 commits intoatmtools:mainfrom
riclarsson:rtepack-io-fix
Mar 9, 2026
Merged

Fix problem where rtepack types were not parsable (nor probably binary compatible)#1105
riclarsson merged 2 commits intoatmtools:mainfrom
riclarsson:rtepack-io-fix

Conversation

@riclarsson
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make rtepack wrapper types (e.g., stokvec, specmat, propmat, muelmat) correctly parseable/streamable via the XML IO system by fixing binary IO directionality and adding a span-adapter for types that inherit from existing XML-IO-enabled base types.

Changes:

  • Corrects the xml_io_stream binary streaming API to use get(span<T>, bifstream*) for reads and put(span<const T>, bofstream*) for writes.
  • Introduces xml_io_stream_inherit<T, U> to adapt std::span<T> to std::span<U> for binary/text streaming methods.
  • Switches rtepack XML IO specializations to use xml_io_stream_inherit instead of inheriting xml_io_stream<U> directly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/core/xml/xml_io_stream.h Fixes binary IO method signatures and adds xml_io_stream_inherit to bridge span-based IO between derived/base types.
src/core/rtepack/rtepack_stokes_vector.h Updates xml_io_stream<rtepack::stokvec> to use the new inheritance/span adapter.
src/core/rtepack/rtepack_spectral_matrix.h Updates xml_io_stream<rtepack::specmat> to use the new inheritance/span adapter.
src/core/rtepack/rtepack_propagation_matrix.h Updates xml_io_stream<rtepack::propmat> to use the new inheritance/span adapter.
src/core/rtepack/rtepack_mueller_matrix.h Updates xml_io_stream<rtepack::muelmat> to use the new inheritance/span adapter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@riclarsson riclarsson merged commit 537bdc1 into atmtools:main Mar 9, 2026
9 checks passed
@riclarsson riclarsson deleted the rtepack-io-fix branch March 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants