Skip to content

Throw current exception instead of recreate them #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElGigi wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Throw current exception instead of recreate them #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c8c4c
Throw current exception instead of recreate them
ElGigi Nov 2, 2018
5221048
Fix test
ElGigi Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Transaction/AutoTransact.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ public function write(Mapper $mapper, string $method, Record $record) : void
$this->commit();
} catch (Exception $e) {
$this->rollBack();
$c = get_class($e);
throw new $c($e->getMessage(), $e->getCode(), $e);
Copy link
Copy Markdown
Contributor

@harikt harikt May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably casting to int will help here.

public __construct ([ string $message = "" [, int $code = 0 [, Throwable $previous = NULL ]]] )

taken from https://www.php.net/manual/en/exception.construct.php .

So the order of exception seems not changing. Also if this code is removed, that may affect other parts for this can become a BC break for people who rely on multiple exception. ( Just a thought )

throw $e;
}
}
}
3 changes: 1 addition & 2 deletions tests/Transaction/AutoTransactTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ public function testWrite()
$employee->id = '999';
$this->atlas->persist($employee);
} catch (Exception $e) {
$previous = $e->getPrevious();
$this->assertSame(
$previous->getMessage(),
$e->getMessage(),
"Primary key value for 'id' changed"
);
}
Expand Down