fix: add 10s timeout to registry URL validation to prevent CLI hang#2059
Open
zhaog100 wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: add 10s timeout to registry URL validation to prevent CLI hang#2059zhaog100 wants to merge 1 commit intoasyncapi:masterfrom
zhaog100 wants to merge 1 commit intoasyncapi:masterfrom
Conversation
When --registry-url points to an unreachable host, the CLI would hang indefinitely waiting for the fetch request. This adds an AbortController with a 10-second timeout to registryValidation() so the CLI fails fast with a clear error message. Fixes asyncapi#2027
zhaog100
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
--registry-urlpoints to an unreachable host, the CLI hangs indefinitely becausefetch()has no timeout.Solution
Add
AbortControllerwith a 10-second timeout toregistryValidation(). On timeout, the CLI now fails fast with a clear error:Fixes #2027