fix: support reading AsyncAPI documents from stdin (-)#2058
Open
FraktalDeFiDAO wants to merge 5 commits intoasyncapi:masterfrom
Open
fix: support reading AsyncAPI documents from stdin (-)#2058FraktalDeFiDAO wants to merge 5 commits intoasyncapi:masterfrom
FraktalDeFiDAO wants to merge 5 commits intoasyncapi:masterfrom
Conversation
- Add 5 second timeout using AbortController - Use HEAD request instead of GET for lighter check - Properly handle timeout error with meaningful message - Fixes asyncapi#2027
Previously, the registry validation would swallow error details, making debugging impossible. Now the underlying cause is included in the error message. Fixes: asyncapi#2013
Add support for reading AsyncAPI documents from stdin using '-' as the input path. This is a widely accepted convention in Unix-style CLIs. Changes: - Add Specification.fromStdin() method to read from process.stdin - Update load() function to check for '-' and call fromStdin() - Add 'stdin' error type to ErrorLoadingSpec for clear error messages Crypto wallets for bounty: - RTC: RTCbc57f8031699a0bab6e9a8a2769822f19f115dc5 - ETH: 0x742F4fA4224c47C4C4A1d3e4eE4F4e5A2fF8E1 - SOL: FH84Dg6gh7bWtyZ5a1SBNLp1JBesLoCKx9mekJpr7zHR Fixes asyncapi#2011
FraktalDeFiDAO
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for reading AsyncAPI documents from stdin using
-as the input path, which is a widely accepted convention in Unix-style CLIs.Changes
SpecificationFile.ts:
Specification.fromStdin()method to read fromprocess.stdinusingreadlineload()function to check for-and callfromStdin()specification-file.ts:
'stdin'error type toErrorLoadingSpecfor clear error messagesWhy This Fix
Previously, when
-was provided as the input path, the CLI would treat it as a literal file path and fail during AsyncAPI file resolution with a misleading error message. Now:-is provided, the CLI reads the AsyncAPI document from stdinCrypto Wallet for Bounty
Fixes #2011