Skip to content

fix: add timeout to registry validation to prevent indefinite hanging#2057

Open
ryan-the-zilla wants to merge 1 commit intoasyncapi:masterfrom
ryan-the-zilla:fix-registry-timeout
Open

fix: add timeout to registry validation to prevent indefinite hanging#2057
ryan-the-zilla wants to merge 1 commit intoasyncapi:masterfrom
ryan-the-zilla:fix-registry-timeout

Conversation

@ryan-the-zilla
Copy link

What this PR does

Fixes #2027 - CLI hangs indefinitely when --registry-url points to an unreachable host.

Changes Made:

  • Added AbortController with 10 second timeout to prevent indefinite hanging
  • Changed HTTP method from GET to HEAD for lightweight validation
  • Improved error messages to distinguish between timeout and network errors
  • Properly clears timeout to avoid memory leaks

Testing:

  • Manual testing with unreachable URLs (blackholed IPs)
  • Verified timeout triggers correctly after 10 seconds
  • Confirmed proper error messages are shown

Related Issue:

Part of Bounty Program 2026-04 (#2039)

Wallet for Bounty:

AqE264DnKyJci9kV4t3eYhDtFB3H88HQusWtH5odSqHM

- Added AbortController with 10s timeout
- Changed from GET to HEAD request for lightweight validation
- Improved error messages for timeout and network errors
- Prevents CLI from hanging when registry URL is unreachable

Fixes asyncapi#2027
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

⚠️ No Changeset found

Latest commit: caac381

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] CLI hangs indefinitely when --registry-url points to an unreachable host (no timeout handling)

1 participant