fix: skip redundant AsyncAPI examples fetch when already cached (issue #2015)#2053
Open
FraktalDeFiDAO wants to merge 4 commits intoasyncapi:masterfrom
Open
fix: skip redundant AsyncAPI examples fetch when already cached (issue #2015)#2053FraktalDeFiDAO wants to merge 4 commits intoasyncapi:masterfrom
FraktalDeFiDAO wants to merge 4 commits intoasyncapi:masterfrom
Conversation
- Add 5 second timeout using AbortController - Use HEAD request instead of GET for lighter check - Properly handle timeout error with meaningful message - Fixes asyncapi#2027
Previously, the registry validation would swallow error details, making debugging impossible. Now the underlying cause is included in the error message. Fixes: asyncapi#2013
FraktalDeFiDAO
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2015
Summary
Fixes issue #2015 - skip redundant AsyncAPI examples fetch when already cached.
Problem
The
scripts/fetch-asyncapi-example.jsscript runs on every build, downloading and parsing examples even whenassets/examples/examples.jsonalready exists and is up-to-date. This causes:Solution
Added a
shouldFetchExamples()function that checks ifexamples.jsonexists and is non-empty before fetching. The script now skips network operations when examples are already cached.Changes
EXAMPLES_JSON_PATHconstantshouldFetchExamples(force)function that:trueif--forceor-fflag is passedtrueif examples directory doesn't existtrueifexamples.jsondoesn't existtrueifexamples.jsonis emptyfalseotherwise (skip fetching)--forceor-fflagsUsage
Bounty Submission
Crypto wallets for bounty: