fix: reuse loaded AsyncAPI input to avoid duplicate parsing (issue #2017)#2052
Open
FraktalDeFiDAO wants to merge 3 commits intoasyncapi:masterfrom
Open
fix: reuse loaded AsyncAPI input to avoid duplicate parsing (issue #2017)#2052FraktalDeFiDAO wants to merge 3 commits intoasyncapi:masterfrom
FraktalDeFiDAO wants to merge 3 commits intoasyncapi:masterfrom
Conversation
- Add 5 second timeout using AbortController - Use HEAD request instead of GET for lighter check - Properly handle timeout error with meaningful message - Fixes asyncapi#2027
Previously, the registry validation would swallow error details, making debugging impossible. Now the underlying cause is included in the error message. Fixes: asyncapi#2013
FraktalDeFiDAO
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2017
Summary
Fixes issue #2017 - duplicate AsyncAPI file parsing in
fromTemplatecommand.Problem
The
fromTemplatecommand was loading the AsyncAPI file twice:const asyncapiInput = await this.loadAsyncAPIInput(asyncapi);specification = await load(asyncapi);The first loaded result was discarded and re-parsed unnecessarily.
Solution
Reuse
asyncapiInputdirectly instead of callingload(asyncapi)again. TheloadAsyncAPIInputmethod already returns aSpecificationobject.Changes
load(asyncapi)callasyncapiInputdirectly asspecificationValidationErrorimportBenefits
Bounty Submission
Crypto wallets for bounty: