fix: prevent double-stringification in appendAsyncAPIDocument#2049
Open
FraktalDeFiDAO wants to merge 2 commits intoasyncapi:masterfrom
Open
fix: prevent double-stringification in appendAsyncAPIDocument#2049FraktalDeFiDAO wants to merge 2 commits intoasyncapi:masterfrom
FraktalDeFiDAO wants to merge 2 commits intoasyncapi:masterfrom
Conversation
- Add 5 second timeout using AbortController - Use HEAD request instead of GET for lighter check - Properly handle timeout error with meaningful message - Fixes asyncapi#2027
Only stringify when input is an object, not already a string. This fixes the issue where AsyncAPI documents in ZIP archives were being double-stringified. Fixes: asyncapi#2026
FraktalDeFiDAO
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2026
Summary
Fixes issue #2026 - AsyncAPI documents in generated ZIP archives are double-stringified.
Problem
The
appendAsyncAPIDocumentfunction was callingJSON.stringify()on input that was already a string, resulting in a serialized JSON string literal instead of valid YAML/JSON in the archive.Solution
Updated
appendAsyncAPIDocumentto acceptstring | objecttype. Only stringify when input is an object. Pass string directly when input is already a string.Changes
string | objectBounty Submission
Crypto wallets for bounty: