Skip to content

fix: add timeout to registry URL validation to prevent indefinite hangs (fixes #2027) #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chengfei-gh wants to merge 1 commit into from
Closed

fix: add timeout to registry URL validation to prevent indefinite hangs (fixes #2027) #2042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/utils/generate/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,25 @@

export async function registryValidation(registryUrl?: string, registryAuth?: string, registryToken?: string) {
if (!registryUrl) { return; }

const controller = new AbortController();
const timeoutMs = 10000;
const timeoutId = setTimeout(() => controller.abort(), timeoutMs);

try {
const response = await fetch(registryUrl as string);
const response = await fetch(registryUrl as string, {

Check warning on line 17 in src/utils/generate/registry.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 


See more on https://sonarcloud.io/project/issues?id=asyncapi_cli&issues=AZz2rWVCURlzWYIvvDRH&open=AZz2rWVCURlzWYIvvDRH&pullRequest=2042
method: 'HEAD',
signal: controller.signal,
});
if (response.status === 401 && !registryAuth && !registryToken) {
throw new Error('You Need to pass either registryAuth in username:password encoded in Base64 or need to pass registryToken');
}
} catch {
} catch (err: unknown) {
if (err instanceof Error && err.name === 'AbortError') {
throw new Error(`Timeout fetching registryURL after ${timeoutMs}ms: ${registryUrl}`);
}
throw new Error(`Can't fetch registryURL: ${registryUrl}`);
} finally {
clearTimeout(timeoutId);
}
}
Loading