Open
Conversation
…ty in mask handling for `TiltSolution`.
- Renamed crossdisp -> cdisp. - Revised the tilt correction tests.
… If give, the trace will be used to set the reference pixel.
…plified tilt correction tests by introducing an additional fixture.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 90.45% 90.93% +0.47%
==========================================
Files 16 18 +2
Lines 1855 2139 +284
==========================================
+ Hits 1678 1945 +267
- Misses 177 194 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e included in the astropy-learn tutorials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
specreduce.tilt_correction.TiltCorrectionandspecreduce.tilt_solution.TiltSolutionclasses. TheTiltCorrectionclass can be used to estimate the 2D tilt distortion as an astropyPolynomial2Dmodel from (optionally multiple) arc frame(s), while theTiltSolutionclass can be used to access the tilt-corrected to detector mapping and its inverse, resample science frames, or export the tilt model as aGWCSobject.LLM usage: I've used Claude Code (Opus 4.6) to revise the language in the documentation, revise the docstrings, find and fix several bugs, improve the documentation of some parts of the code, and to implement the
TiltSolution._calculate_inversemethod (that I had implemented myself earlier, then removed since I considered it unnecessary, until I realized it may be quite necessary indeed in the future, but was too lazy to find the commit where I still had it). Additionally, I used Grammarly to fix the grammar in this PR description.