This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Replace rust_macro test to work on nightly#511
Merged
djc merged 1 commit intoaskama-rs:mainfrom Jul 2, 2021
Kijewski:pr-nightly-tokentree
Merged
Replace rust_macro test to work on nightly#511djc merged 1 commit intoaskama-rs:mainfrom Kijewski:pr-nightly-tokentree
djc merged 1 commit intoaskama-rs:mainfrom
Kijewski:pr-nightly-tokentree
Conversation
Collaborator
|
I'm sick and likely somewhat unavailable for the foreseeable future. However, I just wanted to chime in, and say thanks once again :) Sadly, an error message has changed, so now there's still another test failing :( |
Collaborator
|
@vallentin hope you get well soon, get some rest! |
Member
Author
|
Get well soon! |
Member
Author
|
The next broken test is because of rust-lang/rust#82069. It would be possible to utilize rustversion select the right failure? |
The current rust_test uses `stringify!()`. The documentation gives us the warning: > Note that the expanded results of the input tokens may change in the > future. You should be careful if you rely on the output. In the current nightly rust the result was indeed changed, so the test not fails. This PR replaces the test with another macro, that does not depend on `stringify!()`. Closes issue #504.
Collaborator
|
Ahhh, green tests. Thanks! |
djc
approved these changes
Jul 2, 2021
Member
Author
|
You're welcome! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current rust_test uses
stringify!(). The documentation gives usthe warning:
In the current nightly rust the result was indeed changed, so the test
not fails.
This PR replaces the test with another macro, that does not depend on
stringify!().Closes issue #504.