Remove _InheritDocstrings#2049
Merged
sydduckworth merged 2 commits intoMay 13, 2026
Merged
Conversation
sydduckworth
force-pushed
the
remove-inherit-docstrings
branch
from
3074b5f to
be273df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_InheritDocstringsmetaclass_InheritDocstringsseems unnecessary because its intended behavior is already built in to Sphinx (and other docs generators).Additionally it will overwrite the docstring of a child method with the parent docstring even if the child is already documented, which doesn't seem like desired behavior.
This PR produces no changes in the public API documentation.