You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A notable question in this feature is the handling of titles. In most other blocks the translation to strong class="title" works, In a sidebar, I think the title should be a block element, so I've done <p><strong class="title">Title.... But this may lead to the awkward syntax difference between single-paragraph and multi-paragraph sidebars. Notice in the single-paragraph example the title is in a <p> but the content is not in a <p>. But for the multi-paragraph, both the title and content have <p> containers.
<aside>
<p role="heading"><strong class="title">Sidebar Title</strong></p>
This is a sidebar.
</aside>
<aside>
<p role="heading"><strong class="title">Sidebar Title</strong></p>
<p>
This is a sidebar.
</p>
<p>
This is another paragraph in the sidebar.
</p>
</aside>
Another heading is if it is appropriate to give the title's <p> the ARIA role="heading" attribute. It seems appropriate to me.
The alternative to both of these would be to use an <Hn> tag. Although it could be complicated to determine the necessary number, and because it is an <aside> its title probably is irrelevant to the document's structure, and shouldn't be an <Hn> tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and tests for making asciidoc sidebars.