Draft
Conversation
The crg rerender function did not handle the increment arguments correctly which let to issues which are hard to understand for the caller. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
Fix bugs where OpenCRG Matlab API would not handle arguments correctly, remove necessary components of the CRG header, introudce unwanted coordinate shifts, or rely on optional header entries. Resolves: #9 Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
Undoing workarounds that would prevent errors due to the underlying crg check issues. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
Remove fault tolerance, check arguments and throw error on invalid arguments. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
Without copying poff the crg check would fail if mpro is present. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
The extract slope and banking functions introduced or removed offsets from the data. Signed-off-by: Patrick Kuemmerle <patrick.kuemmerle@3d-mapping.de>
fix for #5
fixed error: added missing dim argument to size function removed dead code to write unknown header element data.head.rccl corrected some comments
jorauh
added
isType:Bug
removed obsolete call to crg_check_wgs84, which is now called in crg_check
Contributor
Author
|
#47 (comment): removed obsolete check by 12e4f74 |
crg_mods.m: remove georeferencing data which becomes invalid due to application of modifiers scaling/shifting/rotating the reference line. crg_check_data: don't guess aend - the georeferencing data should only be set if really known.
| %% check NaNs in DATA.z | ||
|
|
||
| data.ir = zeros(1, nu); | ||
| cdata.ir = zeros(1, nu); |
Contributor
There was a problem hiding this comment.
Is this a typo? cdata.ir is never used but data.ir is
Contributor
Author
There was a problem hiding this comment.
Thanks, just corrected.
This was
linked to
issues
Mar 4, 2026
jorauh
added
isState:InProgress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will collect some cleanup of the old (lon/lat/alt based) and new (mpro map projection based) features to achieve
For testing it will be important to get some demo data sets