fix: bug when showing multiple ads on screen - FE-1623#2
Open
mbrowne wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were GPT errors when trying to show more than one ad on the same screen, causing them not to display. This PR fixes that.
Also:
npm installand running tests, so upgrading the build process seemed like the easier path)Note: the npm package
@artnetworldwide/react-dfp@0.22.0was published using theartnet-packagebranch and tagged asv0.22.0, where I renamed the package name to@artnetworldwide/react-dfpand published it manually (see https://github.com/orgs/artnetworldwide/packages/npm/package/react-dfp) since we don't have CI set up for this. We might not need CI if the maintainer of the open-source repo accepts my PR.