Merged
Conversation
Add resumeFrom() to round player so the pie chart can advance the dropdown during auto-play without stopping playback. When the pie chart skips a round with no transfers, updateRound() now calls resumeFrom() instead of setStep() to keep the animation going. Co-Authored-By: Claude Opus 4.6
Revert round-player.js changes. The simpler approach is to skip the setStep() call entirely during auto-play so it does not stop playback. The round player timer catches up on its next tick. Co-Authored-By: Claude Opus 4.6
The no-transfer round skipping has been reverted from the pie chart component, so the workaround in updateRound is no longer needed. Co-Authored-By: Claude Opus 4.6
Skip no-transfer rounds during pie chart animation by requesting the controller to advance immediately. Remove firstStepHoldTimeMs workaround since the first step now fires immediately. Co-Authored-By: Claude Opus 4.6
The timer delay is for between steps, not before the first one. Removes the need for the firstStepHoldTimeMs workaround. Co-Authored-By: Claude Opus 4.6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 96.10% 96.09% -0.02%
==========================================
Files 133 133
Lines 6346 6346
==========================================
- Hits 6099 6098 -1
- Misses 247 248 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #618 with Heroku tests runnable