Merged
Conversation
Fixes "Permission denied" error in CI when running `just build`, which calls ./scripts/build.sh.
- add parseFlatFile, parseXmlFile, and validateFecFile test suites covering parsing, validation, edge cases, and cross-format consistency - add vitest config for the engine package with jsdom environment - add FEC sample files in both flat (txt) and XML formats, including XSD schemas for validation reference - add flat-to-xml.mjs conversion script for generating XML samples from flat files - fix XML parser to extract EcritureLib, PieceRef, and PieceDate from the ecriture element instead of the ligne element - run engine tests during Docker build with cache-busting ARG - pass arguments through justfile build recipe to build.sh - add --progress=plain and CACHEBUST build-arg to build.sh jsdom: 26.1.0 vitest: 4.0.18
- add checks #20-25: empty lines, field count mismatch, dot decimal separator, thousands separator, date year range (1900-2099), and debit/credit mutual exclusivity - track line-level parsing issues (empty lines, field count mismatches) via new lineIssues array in FecParsedFile and FecParsedLineIssue type - convert XML Montant/Sens to Debit/Credit when Debit/Credit elements are absent in parseXmlFile - add comprehensive test suites for all 25 checks, flat file line issue tracking, and Montant/Sens conversion - update README with new checks table (#20-25) and add legal/reference links section - update website navbar with icons and reorder site title to "FEC - Arrhes" - bump version to v0.2.0 - add .dev/ directory with Test-Compta-Demat reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.