LookoutUI: configure displayname

[d2burkhalter]

What type of PR is this?

This PR allows operators to configure which oidc claim is used to display a username

What this PR does / why we need it

Currently the username is set to the sub claim which is not always human readable for example when doing local development using authentication with Keycloak
Default:

With uiConfig.oidc.displayNameClaim=name:

Special notes for your reviewer

[greptile-apps]

Greptile Summary

This PR allows operators to configure which OIDC claim is used to display the username in LookoutUI (defaulting to sub), making local development with Keycloak more ergonomic. It refactors the anonymous OIDC struct in Go into a named OidcConfig type, adds displayNameClaim to both the Go and TypeScript config types, and reads the claim in the useUsername hook with a proper string-type guard and a console.warn fallback when the claim is absent or non-string.

Confidence Score: 5/5

Safe to merge — all previous review concerns are addressed and no new issues introduced.

All previously flagged concerns (type narrowness, silent fallback, YAML comment) are addressed in this revision. The implementation follows established codebase patterns (module-level getConfig() is used in 29 other files). No new logic or security issues found.

No files require special attention.

Important Files Changed

Filename	Overview
internal/lookoutui/src/oidcAuth/hooks.ts	Reads displayNameClaim from config, validates the profile value is a string, warns and falls back to sub if not — well-implemented.
internal/lookout/configuration/types.go	Extracts the inline anonymous OIDC struct into a named OidcConfig type and adds optional DisplayNameClaim *string field with clear documentation.
internal/lookoutui/src/config/types.ts	Adds displayNameClaim?: string to OidcConfig interface — typed as plain string to allow custom OIDC claims, matching the Go side.
_local/lookout/config-auth.yaml	Adds displayNameClaim: "name" to the local dev Keycloak config with a clear, accurate comment.

Sequence Diagram

sequenceDiagram
    participant Op as Operator Config
    participant Go as Go UIConfig (types.go)
    participant TS as TypeScript OidcConfig (types.ts)
    participant Hook as useUsername hook (hooks.ts)
    participant OIDC as OIDC Provider

    Op->>Go: displayNameClaim: "name"
    Go->>TS: JSON: { displayNameClaim: "name" }
    Hook->>OIDC: getUser()
    OIDC-->>Hook: user.profile { sub, name, ... }
    Hook->>Hook: config.oidc.displayNameClaim = "name"
    Hook->>Hook: profile["name"] === string? setUsername("name")
    Hook->>Hook: else console.warn + setUsername(sub)

Loading

_{Reviews (3): Last reviewed commit: "Merge branch 'master' into fix/configure..." | Re-trigger Greptile}