fix(chroma): serialize local store and query engine initialization#171
Merged
mpekatsoula merged 2 commits intomainfrom Mar 17, 2026
Merged
fix(chroma): serialize local store and query engine initialization#171mpekatsoula merged 2 commits intomainfrom
mpekatsoula merged 2 commits intomainfrom
Conversation
Contributor
mpekatsoula
commented
Mar 12, 2026
mpekatsoula
commented
- Add thread-safe lazy initialization for Metis query engines and the Chroma persistent store to prevent duplicate concurrent setup.
- Pin the Chroma backend to the embedded local implementation so this store cannot be redirected away from local mode by env-backed settings.
- Update Chroma client cleanup to use close() and add regression tests for concurrent initialization and backend pinning.
- Add thread-safe lazy initialization for Metis query engines and the Chroma persistent store to prevent duplicate concurrent setup. - Pin the Chroma backend to the embedded local implementation so this store cannot be redirected away from local mode by env-backed settings. - Update Chroma client cleanup to use close() and add regression tests for concurrent initialization and backend pinning.
Contributor
Author
|
Fixes: #134 |
aaronjb
approved these changes
Mar 17, 2026
Contributor
aaronjb
left a comment
aaronjb
left a comment
There was a problem hiding this comment.
Don't see any problems here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.