Conversation
Filter out desktop-only features (source editor toggle, version history, share drawer) from the mobile bottom bar and overflow menu. Settings and file drawers remain accessible on mobile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for rsm-studio-frontend canceled.
|
✅ Deploy Preview for rsm-studio-site canceled.
|
Playwright's :text() pseudo-selector doesn't work inside CSS :has().
Replaced with .filter({ hasText }) and scoped locators to the
[data-testid="context-menu"] container.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The e2e test searched for a[href*="/ws/"] links which don't exist —
the app uses router.push('/file/:id'). The test stayed on the home
page where HamburgerMenu has the same data-testid as the workspace
overflow menu, causing the context-menu assertion to fail.
- Navigate to workspace by clicking file-item elements
- Remove if-guards that allowed tests to pass vacuously
- Fix invalid kind="ghost" → kind="tertiary" on SidebarMenu Button
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
Needs human reviewWhat changed: Source editor toggle, version history drawer, and share drawer are hidden from the mobile workspace bottom bar and overflow menu. Review checklist:
What to look for:
|
Preview DeployFrontend: https://pr-370--rsm-studio-frontend.netlify.app Test user: This preview will be destroyed when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
SidebarMenu.mobile.test.js— verifies source/versions/share hidden, search/settings/file kept on mobile, all items shown on desktopmobile-workspace-features.spec.js— verifies mobile viewport hides source toggle and versions/share from overflow menu🤖 Generated with Claude Code