docs, tests, benchmarks: improve trustworthiness and usability#44
Merged
gabriel-barrett merged 2 commits intomainfrom Mar 19, 2026
Merged
docs, tests, benchmarks: improve trustworthiness and usability#44gabriel-barrett merged 2 commits intomainfrom
gabriel-barrett merged 2 commits intomainfrom
Conversation
ca39a6f to
69adcbe
Compare
gabriel-barrett
approved these changes
Mar 19, 2026
Soundness & documentation: - Add protocol documentation to prover and verifier modules - Add full soundness argument to verifier with notation, per-component bounds (FRI, constraint folding, OOD, lookup, Fiat-Shamir), and overall soundness error formula - Annotate each verification step with inline soundness comments - Add security parameter docs to FriParameters - Document unused InvalidClaim variant Testing: - Replace ignored 2^20-row benchmark test with fast 2^4-row test including serialization round-trip - Add adversarial verifier tests: wrong claim, tampered stage-1 values, tampered accumulator, truncated proof, serialization round-trip - Trim blake3 test_all_claims from 9 redundant runs to 6 minimal ones - CI: run tests with --features parallel, add --all-features to clippy Benchmarks & examples: - Add Criterion benchmarks (prove/verify) - Add examples: simple_proof (no lookups), preprocessed_proof (preprocessed trace with lookups), and lookup_proof (multi-circuit) Repo cleanup: - Rename chips/ to test_circuits/, move Blake3 helpers into blake3.rs - Drop the "chip" terminology elsewhere - Gate test_circuits module with #[cfg(test)] - Add .cargo/config.toml with target-cpu=native - Rewrite README with crypto setup, quick start, and soundness reference
387a176 to
8d9b60c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soundness & documentation:
Testing:
Benchmarks & examples:
Repo cleanup: