Octoprint 2.0.0 fixes#3
Open
jacopotediosi wants to merge 5 commits into
Open
Conversation
This was done via the "octoprint dev plugin:migrate-to-pyproject" command, with minor manual adjustments to the generated files. Ref: https://docs.octoprint.org/en/dev/plugins/migration_pyproject_toml.html
It has been removed in OctoPrint 2.0.0 and it was never intended for public use
To prevent XSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm an active contributor to OctoPrint core. I helped ship OctoPrint 2.0.0rc1 and I'm now helping plugins stay compatible with the new and upcoming OctoPrint releases, which is why you're receiving this PR.
This PR fixes the compatibility issues preventing this plugin from being installed on OctoPrint 2.0.0rc1.
In particular:
printer._commandprinter._get_free_remote_name, which no longer exist in OctoPrint 2.0.0 (ref) and were never intended for public use. In doing so, I also removed_get_remote_filename, which is a fallback that should never be needed, as I can't imagine a case where the vfat ioctl would fail to calculate the short filename.is_template_autoescaped(ref).pyproject(ref). This has been done via theoctoprint dev plugin:migrate-to-pyprojectcommand, with minor manual adjustments to the generated files.I tested the installation on both OctoPrint 2.0.0rc1 and the latest stable version 1.11.7, and now the plugin installs correctly and doesn't log any warnings. Please note that I don't have the hardware to actually test the plugin's functionality, so that's up to you.