-
Notifications
You must be signed in to change notification settings - Fork 0
Fix logo hover color #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
torn4dom4n
wants to merge
2
commits into
main
from
fix-logo-hover-color-4844080748516041056-17866433223946450887
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| I have fixed the issue where the logo particles did not animate (scatter) on hover. | ||
|
|
||
| Changes: | ||
| 1. Reverted the previous commit that changed particle colors, as requested. | ||
| 2. Fixed the hover animation logic in src/App.tsx by removing a restrictive check (isTouchingRef.current || !("ontouchstart" in window)) that was preventing mouse interaction on many systems. | ||
| 3. Updated handleMouseLeave to correctly reset the mouse position to { x: 0, y: 0 } on all platforms, ensuring particles return to their base positions when the mouse leaves the canvas. | ||
| 4. Verified that the hover animation (scattering) works correctly while keeping the particles white. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
|
|
||
| VITE+ v0.1.13 | ||
|
|
||
| ➜ Local: http://localhost:5173/ | ||
| ➜ Network: use --host to expose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
isTouchingRef.current || !("ontouchstart" in window)check makes the scatter branch run on touch-capable browsers even when the user is not interacting. In that idle statemousePositionRefremains{x: 0, y: 0}, so particles near the top-left keep being repelled (notably on smaller/mobile layouts where the logo reaches that area), which regresses the resting logo shape that was previously preserved unless a touch gesture was active.Useful? React with 👍 / 👎.