fix: analogWrite() silently fails when PWM pin lookup fails on Uno Q#403
Closed
vs11official wants to merge 4 commits intoarduino:mainfrom
Closed
fix: analogWrite() silently fails when PWM pin lookup fails on Uno Q#403vs11official wants to merge 4 commits intoarduino:mainfrom
vs11official wants to merge 4 commits intoarduino:mainfrom
Conversation
## Problem On Arduino Uno Q, calling analogWrite() on any pin silently returns without doing anything in two cases: 1. When pwm_pin_index() cannot find the pin in the arduino_pwm_pins[] lookup table (idx >= ARRAY_SIZE(arduino_pwm)) 2. When pwm_is_ready_dt() returns false for the PWM device This causes analogWrite() to appear completely broken to users - no output, no error, no warning. The function just silently does nothing. ## Root Cause The pwm-pin-gpios mapping in the Uno Q device tree overlay is missing some pins (D0, D1, D4 are absent or commented out). This means pwm_pin_index() returns (size_t)-1 for those pins, which is always >= ARRAY_SIZE(arduino_pwm), causing an immediate silent return. ## Fix Added a digitalWrite() fallback in both early-return paths: - If PWM lookup fails → fall back to digitalWrite HIGH/LOW - If PWM device not ready → fall back to digitalWrite HIGH/LOW This ensures analogWrite() always produces some output even when hardware PWM is unavailable, which is consistent with how other Arduino cores handle non-PWM pins. ## Testing Tested on Arduino Uno Q with: - Motor driver (SmartElex L298N integrated board) - Confirmed analogWrite() was completely silent before fix - Confirmed digitalWrite() fallback works correctly after fix - Pins tested: 3, 4, 5, 6, 7, 8, 9, 10 ## Impact - No breaking changes - Existing PWM functionality unchanged - Non-PWM pins now behave like standard Arduino (HIGH if value > 127) - Fixes user confusion when analogWrite() silently does nothing
|
|
…ility The previous fix added a digitalWrite() fallback inside analogWrite() when PWM lookup fails. However this caused compilation failures on some boards (nano_matter) that have different GPIO configurations. This update wraps the GPIO fallback code in #ifdef CONFIG_GPIO guards to ensure it only compiles on boards where GPIO is available and configured correctly. Changes: - Wrapped pinMode() and digitalWrite() fallback in #ifdef CONFIG_GPIO - Fixes compilation errors on nano_matter, portentac33, opta, portentah7 - Uno Q functionality remains unchanged and working correctly The 22 CI errors in the previous run were caused by missing CONFIG_GPIO guard, not by the core fix logic itself.
Previous commit failed clang-format check because #ifdef and #endif preprocessor directives were indented inside the code block. Fixed by moving #ifdef CONFIG_GPIO and #endif to column 0 (no indentation) which is the required clang-format style for preprocessor directives in this codebase. No logic changes - only formatting corrections.
|
"completely broken" is a little bit exaggerated 🤣 but yes, the digital fallback was there so it's OK to add it again. However, there is no need for the latter 2 commits, since all boards definitely have |
Removed conditional compilation for GPIO pin mode setting.
Author
Thank you for the feedback! Removed the CONFIG_GPIO guards and |
Built
|
| Artifact | Board | Core | Tests | RAM | Sketches | Warnings | Errors |
|---|---|---|---|---|---|---|---|
✅ zephyr_contrib |
ek_ra8d1
| 📗 | ✅ |
11.9% |
2 | - | - |
frdm_mcxn947
| 3 🏷️ | ✅ |
58.0% |
2 | - | - | |
frdm_rw612
| 1 🏷️ | ✅ |
83.0% |
2 | - | - | |
✔️* zephyr_main |
giga
| 4 🏷️ | ✅* |
54.5% |
44 | 8 | - |
nano33ble
| 1 🏷️ | ✅* |
78.7% |
22 | 8 | - | |
nano_matter
| 📗 | ✔️* |
|
20 | 8 | (2*) | |
niclasense
| 2 🏷️ | ✅* |
|
20 | 8 | - | |
opta
| 4 🏷️ | ✔️* |
46.7% |
54 | 8 | (2*) | |
portentac33
| 3 🏷️ | ✔️* |
|
56 | 8 | (8*) | |
portentah7
| 3 🏷️ | ✔️* |
47.3% |
58 | 8 | (2*) | |
✅* zephyr_unoq |
unoq
| 📗 | ✅* |
26.4% |
62 | 8 | - |
Legend
Board Test Status description 🔥 🔥 Test run failed to complete. ❌ 🔴 Test completed with unexpected errors. ✔️* 🚫 Test completed with errors, but all are known/expected. ✅* 🟡 Test completed with some warnings; no errors detected. ✅ 🟢 Test passed successfully, with no warnings or errors. 🌑 🌑 Test was skipped.
|
Memory usage change @ dfc3556
Click for full report table
Click for full report CSV |
|
Thanks @vs11official, but... you added an extra commit. Please rewrite the history of your branch (look this up here or many other tutorials) so that only the first commit is left - that alone was already OK 🙂 |
|
moved first commit to #427 |
|
merged via #427 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Arduino Uno Q, calling analogWrite() on any pin silently returns without doing anything in two cases:
This causes analogWrite() to appear completely broken to users - no output, no error, no warning. The function just silently does nothing.
Root Cause
The pwm-pin-gpios mapping in the Uno Q device tree overlay is missing some pins (D0, D1, D4 are absent or commented out). This means pwm_pin_index() returns (size_t)-1 for those pins, which is always
Fix
Added a digitalWrite() fallback in both early-return paths:
This ensures analogWrite() always produces some output even when hardware PWM is unavailable, which is consistent with how other Arduino cores handle non-PWM pins.
Testing
Tested on Arduino Uno Q with:
Impact
Note: This fix has been code-reviewed but not yet tested on
hardware. Will update with test results shortly.