Skip to content

fix: align protobuf runtime constraint with checked-in B01 gencode#8

Draft
arduano wants to merge 4 commits intomainfrom
leo/pr785-followup-protobuf-runtime
Draft

fix: align protobuf runtime constraint with checked-in B01 gencode#8
arduano wants to merge 4 commits intomainfrom
leo/pr785-followup-protobuf-runtime

Conversation

@arduano
Copy link
Copy Markdown
Owner

@arduano arduano commented Mar 31, 2026

Openclaw:

Summary

  • tighten runtime dependency from protobuf>=5,<7 to protobuf>=6,<7
  • keep lockfile metadata in sync with the new constraint
  • document in the B01 proto file that checked-in gencode must be regenerated with protobuf major v6

Why

roborock/map/proto/b01_scmap_pb2.py was generated with protobuf Python 6.31.1 and includes runtime version validation for major v6. Allowing protobuf v5 at runtime can fail import/version checks. This PR makes dependency/runtime expectations explicit and consistent.

Validation

  • uv lock
  • ruff format --check . && ruff check .
  • uv run pytest --log-cli-level=DEBUG -vv -s --cov --cov-branch --cov-report=xml (425 passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants