Skip to content

refactor: Rename inconsistency concepts - MME→TEAM, UME→MEAT #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfuchss merged 1 commit into from
Feb 5, 2026
Merged

refactor: Rename inconsistency concepts - MME→TEAM, UME→MEAT #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions architecture_decisions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,12 @@ Sample response for waiting for the result or retrieving the result using getRes
],
"inconsistencies": [
{
"type": "MissingModelInstance",
"type": "TextEntityAbsentFromModel",
"reason": "Text indicates that \"integrations\" should be contained in the model(s) but could not be found. (confidence: 0.65)",
"sentenceNumber": 39
},
{
"type": "MissingTextForModelElement",
"type": "ModelEntityAbsentFromText",
"reason": "Model contains an Instance \"Recording Service\" (type: \"uml:Component\") that seems to be undocumented.",
"modelElementId": "_kvWs4FkHEeyewPSmlgszyA"
}
Expand Down
18 changes: 9 additions & 9 deletions src/main/java/edu/kit/kastel/mcse/ardoco/tlr/rest/api/converter/InconsistencyConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Licensed under MIT 2025. */
/* Licensed under MIT 2025-2026. */
package edu.kit.kastel.mcse.ardoco.tlr.rest.api.converter;

import org.eclipse.collections.api.list.ImmutableList;
Expand All @@ -9,8 +9,8 @@
import com.fasterxml.jackson.databind.node.ObjectNode;

import edu.kit.kastel.mcse.ardoco.core.api.stage.inconsistency.Inconsistency;
import edu.kit.kastel.mcse.ardoco.id.types.MissingModelInstanceInconsistency;
import edu.kit.kastel.mcse.ardoco.id.types.MissingTextForModelElementInconsistency;
import edu.kit.kastel.mcse.ardoco.id.types.ModelEntityAbsentFromTextInconsistency;
import edu.kit.kastel.mcse.ardoco.id.types.TextEntityAbsentFromModelInconsistency;

public final class InconsistencyConverter {

Expand All @@ -26,12 +26,12 @@ public static String convertInconsistencyToJsonString(ImmutableList<Inconsistenc
ObjectNode traceLinkNode = objectMapper.createObjectNode();
traceLinkNode.put("type", inconsistency.getType());
traceLinkNode.put("reason", inconsistency.getReason());
if (inconsistency.getType().equals("MissingModelInstance")) {
MissingModelInstanceInconsistency mmiInconsistency = (MissingModelInstanceInconsistency) inconsistency;
traceLinkNode.put("sentenceNumber", mmiInconsistency.getSentenceNumber());
} else if (inconsistency.getType().equals("MissingTextForModelElement")) {
MissingTextForModelElementInconsistency umeInconsistency = (MissingTextForModelElementInconsistency) inconsistency;
traceLinkNode.put("modelElementId", umeInconsistency.getModelInstanceUid());
if (inconsistency.getType().equals("TextEntityAbsentFromModel")) {
TextEntityAbsentFromModelInconsistency teamInconsistency = (TextEntityAbsentFromModelInconsistency) inconsistency;
traceLinkNode.put("sentenceNumber", teamInconsistency.getSentenceNumber());
} else if (inconsistency.getType().equals("ModelEntityAbsentFromText")) {
ModelEntityAbsentFromTextInconsistency meatInconsistency = (ModelEntityAbsentFromTextInconsistency) inconsistency;
traceLinkNode.put("modelElementId", meatInconsistency.getModelInstanceUid());
}
arrayNode.add(traceLinkNode);
}
Expand Down
Loading