fix: use correct pydantic le constraint for element_bits#43
Open
shuofengzhang wants to merge 1 commit intoarcee-ai:mainfrom
Open
fix: use correct pydantic le constraint for element_bits#43shuofengzhang wants to merge 1 commit intoarcee-ai:mainfrom
shuofengzhang wants to merge 1 commit intoarcee-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lte=64withle=64inQuantizationBin.element_bits(distillkit/compression/config.py).Why
leis the valid keyword for "less than or equal" constraints.lteis treated as an extra/unknown Field argument, which triggers a deprecation warning and does not enforce the intended bound.element_bits <= 64) and removes the warning noise.Testing
source .venv/bin/activate && pytest -q10 passed in 3.20sNote
Low Risk
Low risk: a one-line Pydantic field constraint fix that restores the intended
element_bits <= 64validation and removes deprecation/extra-arg warnings.Overview
Fixes
QuantizationBin.element_bitsvalidation by replacing the Pydantic field constraintlte=64withle=64, ensuring the<= 64bound is actually enforced under Pydantic v2 and avoiding extra/unknown Field-arg warnings.Written by Cursor Bugbot for commit 579f8fa. This will update automatically on new commits. Configure here.