Skip to content

chore: fix typos across codebase #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukrucildirr wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

chore: fix typos across codebase #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
495d7fe
Update train_rage2e.py
sukrucildirr Sep 11, 2025
65fdae2
Update regex_based.py
sukrucildirr Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dalm/datasets/reading_comprehension_generation/regex_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def get_all_templates(self, entry: Dict[str, Any], random_seed: int) -> List[Tup
("What is the result of the following sentence?\n{cause}\nResult:", "{effect}"),
('Q: What happens after "{cause}"? A:', "{effect}"),
("{cause}\nWhat happens next?", "{effect}"),
# More varaiations
# More variations
("Considering the cause: {cause}\nWhat could be the resulting effect?", "{effect}"),
("Given that: {cause}\nWhat do you anticipate as the outcome?", "{effect}"),
('What could stem from "{cause}"?', "{effect}"),
Expand Down Expand Up @@ -495,7 +495,7 @@ def format_single_demo(self, entry: Dict[str, Any], random_seed: int) -> List[Di
elif entry["relation"] == "Effect-cause":
kw_dic["cause"] = entry["sentence2"][0].upper() + entry["sentence2"][1:]
kw_dic["effect"] = entry["sentence1"]
elif entry["relation"] == "Explanantion":
elif entry["relation"] == "Explanation":
kw_dic["sentence1"] = entry["sentence1"]
kw_dic["sentence2"] = entry["sentence2"][0].upper() + entry["sentence2"][1:]

Expand Down
2 changes: 1 addition & 1 deletion dalm/training/rag_e2e/train_rage2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def train_e2e(
generator_tokenizer = rag_model.generator_tokenizer
generator_tokenizer.pad_token = generator_tokenizer.eos_token

# TODO: check if this is depdendent on the tokenizer installed
# TODO: check if this is dependent on the tokenizer installed
generator_tokenizer.add_eos_token = True

processed_datasets = dataset.map(
Expand Down