fix(config): resolve olddefconfig validation issues#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ArcBox kernel config fragments to eliminate olddefconfig validation warnings and ensure required dependencies are explicitly satisfied for both arm64 and x86_64 builds.
Changes:
- Remove invalid/unsatisfied options (
CONFIG_HYPERVISOR_GUESTon arm64,CONFIG_CGROUP_HUGETLBon both). - Add missing dependencies for enabled features (arm64:
CONFIG_PERF_EVENTS=y; both arches:CONFIG_MD=yto enable the RAID/LVM + Device Mapper menu). - Deduplicate pseudo-filesystem and modules entries that were triggering
olddefconfigwarnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| configs/arcbox-x86_64.config | Removes unsatisfied/duplicate options and enables CONFIG_MD to support DM features cleanly under olddefconfig. |
| configs/arcbox-arm64.config | Drops x86-only CONFIG_HYPERVISOR_GUEST, adds CONFIG_PERF_EVENTS for CGROUP_PERF, enables CONFIG_MD, and removes duplicates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ARM64: remove CONFIG_HYPERVISOR_GUEST (x86-only option), add CONFIG_PERF_EVENTS to satisfy CGROUP_PERF dependency, add CONFIG_MD to enable Device Mapper menu (BLK_DEV_DM, DM_THIN_PROVISIONING). x86_64: add CONFIG_MD for Device Mapper support. Both: remove CONFIG_CGROUP_HUGETLB (depends on HUGETLB_PAGE which is intentionally disabled), deduplicate TMPFS/PROC_FS/SYSFS/MODULES entries that caused olddefconfig warnings. Validated with `make olddefconfig` on kernel 6.12.11 for both arches.
PeronGH
force-pushed
the
fix/olddefconfig-validation
branch
from
ce1f9d0 to
29e27f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM64: remove CONFIG_HYPERVISOR_GUEST (x86-only option), add CONFIG_PERF_EVENTS to satisfy CGROUP_PERF dependency, add CONFIG_MD to enable Device Mapper menu (BLK_DEV_DM, DM_THIN_PROVISIONING).
x86_64: add CONFIG_MD for Device Mapper support.
Both: remove CONFIG_CGROUP_HUGETLB (depends on HUGETLB_PAGE which is intentionally disabled), deduplicate TMPFS/PROC_FS/SYSFS/MODULES entries that caused olddefconfig warnings.
Validated with
make olddefconfigon kernel 6.12.11 for both arches.